Skip to content

fix: resolve CI failures on main#7623

Merged
siddseethepalli merged 1 commit into
mainfrom
swarm/4d72/task-9
Feb 24, 2026
Merged

fix: resolve CI failures on main#7623
siddseethepalli merged 1 commit into
mainfrom
swarm/4d72/task-9

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

@siddseethepalli siddseethepalli commented Feb 24, 2026

Fixes CI failures introduced by the daemon-routing refactor PRs (#7595-#7598).

Root Causes

  1. FK constraint failuresCallOrchestrator now creates messages rows via conversationStore.addMessage(), but the messages table FK lacks ON DELETE CASCADE. Test resetTables() functions that delete conversations without first deleting messages would crash.

  2. Missing readHttpToken exportcomputer-use-session-working-dir.test.ts mocked platform.js without the newly-added readHttpToken export.

  3. Stale provider mock in relay-serverrelay-server.test.ts still mocked @anthropic-ai/sdk directly, but CallOrchestrator was migrated to use the provider registry.

  4. Missing guardian action tables — Session tests use in-memory DBs without the new guardian tables, causing getPendingDeliveryByConversation to crash.

  5. Stale IPC snapshotguardian_request_thread_created snapshot had outdated field values.

Changes

  • Added DELETE FROM messages, DELETE FROM guardian_action_deliveries, DELETE FROM guardian_action_requests to resetTables() in all call/relay/twilio test files
  • Added readHttpToken: () => null to platform mock in computer-use test
  • Replaced Anthropic SDK mock with provider registry mock in relay-server tests
  • Wrapped getPendingDeliveryByConversation in try/catch for missing tables
  • Updated IPC snapshot to match current test data

Open with Devin

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27e5725261

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/memory/guardian-action-store.ts
Co-Authored-By: Claude <noreply@anthropic.com>
@siddseethepalli siddseethepalli merged commit e85654d into main Feb 24, 2026
@siddseethepalli siddseethepalli deleted the swarm/4d72/task-9 branch February 24, 2026 05:55
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 4 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/__tests__/relay-server.test.ts
Comment thread assistant/src/memory/guardian-action-store.ts
@siddseethepalli
Copy link
Copy Markdown
Contributor Author

Addressed in #7628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant