fix: resolve CI failures on main#7623
Merged
Merged
Conversation
27e5725 to
52fb825
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27e5725261
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude <noreply@anthropic.com>
52fb825 to
c5a3f55
Compare
Contributor
Author
|
Addressed in #7628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI failures introduced by the daemon-routing refactor PRs (#7595-#7598).
Root Causes
FK constraint failures —
CallOrchestratornow createsmessagesrows viaconversationStore.addMessage(), but themessagestable FK lacksON DELETE CASCADE. TestresetTables()functions that delete conversations without first deleting messages would crash.Missing
readHttpTokenexport —computer-use-session-working-dir.test.tsmockedplatform.jswithout the newly-addedreadHttpTokenexport.Stale provider mock in relay-server —
relay-server.test.tsstill mocked@anthropic-ai/sdkdirectly, butCallOrchestratorwas migrated to use the provider registry.Missing guardian action tables — Session tests use in-memory DBs without the new guardian tables, causing
getPendingDeliveryByConversationto crash.Stale IPC snapshot —
guardian_request_thread_createdsnapshot had outdated field values.Changes
DELETE FROM messages,DELETE FROM guardian_action_deliveries,DELETE FROM guardian_action_requeststoresetTables()in all call/relay/twilio test filesreadHttpToken: () => nullto platform mock in computer-use testgetPendingDeliveryByConversationin try/catch for missing tables