fix: resolve CI failures from PR #7575 and related PRs on main#7613
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failures on main introduced by the cascade of PRs #7575, #7539, #7596, and #7595.
Root causes and fixes:
DrizzleError on DELETE FROM conversations (call-orchestrator, relay-server, call-routes-http, twilio-routes tests): PR M2: Call orchestrator migration to provider abstraction #7596 migrated the call orchestrator to use provider abstraction, which now calls
conversationStore.addMessage()creating rows in themessagestable. Themessagestable has a FK toconversationswithout CASCADE delete, soresetTables()failed when trying to delete conversations with existing messages. Fixed by addingDELETE FROM tool_invocationsandDELETE FROM messagesbeforeDELETE FROM conversations.readHttpToken export not found (computer-use-session-working-dir, call-orchestrator, relay-server, call-routes-http, twilio-routes tests): PR feat: voice first-class channel + cross-channel guardian notifications #7539 introduced
guardian-dispatch.tswhich importsreadHttpTokenfromplatform.ts. Platform mocks missing this export caused Bun module resolution failures. Fixed by addingreadHttpToken: () => nullto all affected platform mocks.SQLiteError: unable to open database file (11 session tests): PR feat: voice first-class channel + cross-channel guardian notifications #7539 added
getPendingDeliveryByConversation()call insession-process.tswhich triggers DB access viaguardian-action-store.ts. Session tests with minimal platform mocks didn't mock this module. Fixed by addingguardian-action-store.jsmock to all 11 session test files.Missing memory config (relay-server, call-orchestrator):
conversationStore.addMessage()callsgetConfig().memoryfor indexing, but config mocks didn't include thememoryfield. Fixed by addingmemory: { enabled: false }to config mocks.IPC snapshot mismatch (ipc-snapshot test): Test data used
conv-guardian-001/call-001but snapshot hadconv-guardian-req-001/call-guardian-001. Fixed by updating snapshot to match test data.CI run: https://github.com/vellum-ai/vellum-assistant/actions/runs/22337653883