Skip to content

fix: resolve CI failures from PR #7575 and related PRs on main#7613

Merged
noanflaherty merged 1 commit into
mainfrom
swarm/e656/fix-ci-7575
Feb 24, 2026
Merged

fix: resolve CI failures from PR #7575 and related PRs on main#7613
noanflaherty merged 1 commit into
mainfrom
swarm/e656/fix-ci-7575

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 24, 2026

Summary

Fixes CI failures on main introduced by the cascade of PRs #7575, #7539, #7596, and #7595.

Root causes and fixes:

  1. DrizzleError on DELETE FROM conversations (call-orchestrator, relay-server, call-routes-http, twilio-routes tests): PR M2: Call orchestrator migration to provider abstraction #7596 migrated the call orchestrator to use provider abstraction, which now calls conversationStore.addMessage() creating rows in the messages table. The messages table has a FK to conversations without CASCADE delete, so resetTables() failed when trying to delete conversations with existing messages. Fixed by adding DELETE FROM tool_invocations and DELETE FROM messages before DELETE FROM conversations.

  2. readHttpToken export not found (computer-use-session-working-dir, call-orchestrator, relay-server, call-routes-http, twilio-routes tests): PR feat: voice first-class channel + cross-channel guardian notifications #7539 introduced guardian-dispatch.ts which imports readHttpToken from platform.ts. Platform mocks missing this export caused Bun module resolution failures. Fixed by adding readHttpToken: () => null to all affected platform mocks.

  3. SQLiteError: unable to open database file (11 session tests): PR feat: voice first-class channel + cross-channel guardian notifications #7539 added getPendingDeliveryByConversation() call in session-process.ts which triggers DB access via guardian-action-store.ts. Session tests with minimal platform mocks didn't mock this module. Fixed by adding guardian-action-store.js mock to all 11 session test files.

  4. Missing memory config (relay-server, call-orchestrator): conversationStore.addMessage() calls getConfig().memory for indexing, but config mocks didn't include the memory field. Fixed by adding memory: { enabled: false } to config mocks.

  5. IPC snapshot mismatch (ipc-snapshot test): Test data used conv-guardian-001/call-001 but snapshot had conv-guardian-req-001/call-guardian-001. Fixed by updating snapshot to match test data.

CI run: https://github.com/vellum-ai/vellum-assistant/actions/runs/22337653883


Open with Devin

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty self-assigned this Feb 24, 2026
@noanflaherty noanflaherty merged commit 9eadea2 into main Feb 24, 2026
@noanflaherty noanflaherty deleted the swarm/e656/fix-ci-7575 branch February 24, 2026 05:43
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant