fix: add name-based fallback to Session.swift isExternalTarget check#7466
Merged
Conversation
When targetAppBundleId is nil but targetAppName is set (e.g. "Chrome"), the inline isExternalTarget check incorrectly evaluated to false, causing the Chrome accessibility NSAlert to steal focus from the app under test. Now falls back to targetAppName matching, consistent with the external app detection logic in AppDelegate+Sessions.swift. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isExternalTargetcheck inSession.swiftto also considertargetAppNamewhentargetAppBundleIdis nil, matching the behavior ofisExternalAppTargetinAppDelegate+Sessions.swifttargetAppBundleIdis nil buttargetAppNameis set (e.g. "Chrome"), the check now correctly identifies the session as targeting an external app, preventing the Chrome accessibility NSAlert from stealing focusTest plan
isExternalTargetisfalse(backward compatibility)🤖 Generated with Claude Code