Skip to content

fix: restrict bundle ID injection to target app matches only#7461

Merged
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/fb-7434
Feb 24, 2026
Merged

fix: restrict bundle ID injection to target app matches only#7461
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/fb-7434

Conversation

@Jasonnnz
Copy link
Copy Markdown
Contributor

@Jasonnnz Jasonnnz commented Feb 24, 2026

Summary

  • Only injects targetAppBundleId when the requested app matches the target app, preventing incorrect bundle ID injection in cross-app workflows
  • Previously, the target app's bundle ID was unconditionally injected when the LLM didn't provide one, causing wrong app activation in cross-app scenarios (e.g., Safari's bundle ID being attached to a Chrome open request)

Test plan

  • Verify single-app workflow still correctly injects targetAppBundleId when LLM omits it
  • Verify cross-app workflow (e.g., "copy from Chrome and paste into Safari") does NOT inject target app's bundle ID when opening a non-target app
  • Verify that when no app_name is provided, the bundle ID is still injected (fallback behavior preserved)

Addresses review feedback from #7434.

🤖 Generated with Claude Code


Open with Devin

In cross-app workflows (e.g., "copy from Chrome and paste into Safari"),
the targetAppBundleId was unconditionally injected when the LLM didn't
provide one. This caused the target app's bundle ID to be attached to
requests for a different app, leading to wrong app activation since
bundle ID takes priority in openApp resolution.

Now only injects targetAppBundleId when the requested app matches the
target app (or no app name is specified).

Addresses review feedback from #7434.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Jasonnnz Jasonnnz merged commit cb58b99 into feature/qa-video-automation Feb 24, 2026
@Jasonnnz Jasonnnz deleted the swarm/fb-7434 branch February 24, 2026 02:37
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant