fix: keep Gmail distinct from Mail in APP_CANONICAL_MAP#7460
Merged
Conversation
The canonical mapping ['gmail', 'mail'] incorrectly collapsed Gmail and Mail into the same canonical key. This caused taskExplicitlyRequestsCrossApp() to record only one app mention for tasks involving both Gmail and Mail, preventing the cross-app escape path from activating. Change the mapping to ['gmail', 'gmail'] so Gmail retains its own canonical identity, allowing cross-app workflows like "copy from Gmail into Mail" to be detected correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_CANONICAL_MAPentry for'gmail'from mapping to'mail'to mapping to'gmail', so Gmail and Mail retain distinct canonical keys.taskExplicitlyRequestsCrossApp()for workflows involving both Gmail and Mail (e.g., "copy from Gmail into Mail").Context
Addresses review feedback from #7409 where both Codex and Devin flagged that
['gmail', 'mail']incorrectly collapses two genuinely different apps into one canonical key, preventing the cross-app escape path from activating.Test plan
taskExplicitlyRequestsCrossApp()to returntrue🤖 Generated with Claude Code