fix: narrow target-app-hints to avoid false-positive matches#7457
Merged
Conversation
- Add word boundary (\b) before action verb group in contextPattern to
prevent partial matches like "login" matching "in" or "domain" matching "in"
- Switch Cursor from simple \bcursor\b to contextPattern('cursor') so
"move cursor to the submit button" no longer triggers a match
- Switch Zoom from simple \bzoom\b to contextPattern('zoom') so
"zoom in on the chart" no longer triggers a match
- Reorder iTerm before Terminal in APP_HINTS array so "open terminal in
iterm2" resolves to iTerm instead of Terminal
- Add regression tests for all five false-positive scenarios
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\bword boundary before action verb group incontextPatternto prevent partial matches (e.g., "login" matching the "in" verb, "domain" matching "in")\bcursor\btocontextPattern('cursor')so UI wording like "move cursor to the submit button" no longer triggers a false match\bzoom\btocontextPattern('zoom')so "zoom in on the chart" no longer triggers a false matchAPP_HINTSarray so "open terminal in iterm2" resolves to iTerm, not TerminalAddresses feedback from #7428.
Test plan
target-app-hints.test.ts🤖 Generated with Claude Code