Skip to content

Fix: Correct misleading comment in PairingQRCodeSheet #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleeradka merged 1 commit into from
Feb 24, 2026
Merged

Fix: Correct misleading comment in PairingQRCodeSheet #7433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/Features/Settings/PairingQRCodeSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct PairingQRCodeSheet: View {
private var canGenerateQR: Bool {
let hasRequiredFields = !gatewayUrl.isEmpty && !resolvedBearerToken.isEmpty
if isLocalOverride {
// For developer local pairing, the gateway is not required
// For developer local pairing, the ingress-enabled flag is not required
// but the URL must be a local/private address
guard let url = URL(string: gatewayUrl), let host = url.host else { return false }
return hasRequiredFields && LocalAddressValidator.isLocalAddress(host)
Expand Down
Loading