Fix remaining SMS/Twilio assistant-scoping parity gaps#7355
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57a05caae7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #7423 |
5 tasks
ashleeradka
pushed a commit
that referenced
this pull request
May 21, 2026
…(LUM-1763) Back-port of vellum-ai/vellum-assistant-platform#7461. Two related iOS prechat polish fixes that landed on the platform side after the onboarding paths were frozen: 1. **Safe-area top spacing.** `NameStepScreen` and `VibeStepScreen` were using a flat `pt-4`, which on iOS slides the back-button row under the status bar / Dynamic Island. Switch to `calc(var(--safe-area-inset-top, env(safe-area-inset-top, 0px)) + 1rem)` so the standard 1rem padding sits on top of the system inset. 2. **Back-nav persistence.** `PreChatFlow` resets to screen 0 on every mount, so an iOS user who taps through to the vibe step and then hot-reloads (or returns after the OS reclaims memory) is silently dropped back to the name step. Remember the position in `sessionStorage` under `prechat_native_screen`; restore on mount; clear on back-from-vibe and on finishNativePreChat. Storage writes are wrapped in try/catch so private-mode contexts don't throw. The other PR in LUM-1763 (#7355 — alex-nork's Sanity connection for the content-automation cohort) is deferred as a cohort- specific feature, not a small drift fix. Verified locally: lint, typecheck clean. https://claude.ai/code/session_01JPGu4yGPTL4JoLaPuqpEW2
ashleeradka
added a commit
that referenced
this pull request
May 21, 2026
…1416) * fix(web): iOS onboarding safe-area + back-nav persistence in prechat (LUM-1763) Back-port of vellum-ai/vellum-assistant-platform#7461. Two related iOS prechat polish fixes that landed on the platform side after the onboarding paths were frozen: 1. **Safe-area top spacing.** `NameStepScreen` and `VibeStepScreen` were using a flat `pt-4`, which on iOS slides the back-button row under the status bar / Dynamic Island. Switch to `calc(var(--safe-area-inset-top, env(safe-area-inset-top, 0px)) + 1rem)` so the standard 1rem padding sits on top of the system inset. 2. **Back-nav persistence.** `PreChatFlow` resets to screen 0 on every mount, so an iOS user who taps through to the vibe step and then hot-reloads (or returns after the OS reclaims memory) is silently dropped back to the name step. Remember the position in `sessionStorage` under `prechat_native_screen`; restore on mount; clear on back-from-vibe and on finishNativePreChat. Storage writes are wrapped in try/catch so private-mode contexts don't throw. The other PR in LUM-1763 (#7355 — alex-nork's Sanity connection for the content-automation cohort) is deferred as a cohort- specific feature, not a small drift fix. Verified locally: lint, typecheck clean. https://claude.ai/code/session_01JPGu4yGPTL4JoLaPuqpEW2 * chore(web): extract goToVibeStep closure (review feedback) Non-blocking observation from the vex-bot review on #31416: `onContinue` and `onSkip` on the iOS NameStepScreen had the same 4-line body (setScreen + sessionStorage.setItem in try/catch), which invites drift if one transition path changes and the other doesn't. Extract a `goToVibeStep` closure inside the screen===0 arm so both callsites point at the same code. https://claude.ai/code/session_01JPGu4yGPTL4JoLaPuqpEW2 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistant_numberusessms.assistantPhoneNumbers[assistantId]before global fallbackcall_start, call HTTP routes, and call-domain start flowsms.assistantPhoneNumbersin gatewayloadConfig()at startup instead of relying solely on config-file watcher mutationValidation
cd assistant && bun test src/__tests__/call-domain.test.tscd assistant && bun test src/__tests__/handlers-twilio-config.test.tscd assistant && bun test src/__tests__/call-routes-http.test.tscd assistant && bun test src/__tests__/sms-messaging-provider.test.ts src/__tests__/channel-guardian.test.tscd assistant && bunx tsc --noEmitcd gateway && bun test src/__tests__/config.test.ts src/http/routes/sms-deliver.test.ts src/http/routes/twilio-sms-webhook.test.ts src/__tests__/sms-ingress-guard.test.tscd gateway && bunx tsc --noEmit