fix: tighten cross-app escape hatch + guard empty fuzzy match#7292
Merged
Jasonnnz merged 1 commit intoFeb 23, 2026
Merged
Conversation
Replace overly broad regex patterns in taskExplicitlyRequestsCrossApp()
with app-name-aware detection that requires two distinct known app names
to be mentioned. The old patterns matched single-app actions like
"switch to dark mode" or "move the file to trash".
Guard fuzzy app matching against empty normalized input to prevent
String.contains("") from matching the first running app arbitrarily
when input like "---" normalizes to an empty string.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
Replace overly broad regex patterns in taskExplicitlyRequestsCrossApp()
with app-name-aware detection that requires two distinct known app names
to be mentioned. The old patterns matched single-app actions like
"switch to dark mode" or "move the file to trash".
Guard fuzzy app matching against empty normalized input to prevent
String.contains("") from matching the first running app arbitrarily
when input like "---" normalizes to an empty string.
Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bef78675f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
Addressed in #7409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback on #7281.
Test plan
🤖 Generated with Claude Code