refactor: simplify channel settings UI to status-first display#7108
Merged
Conversation
Replace complex Telegram and SMS (Twilio) channel cards with compact, status-first layout. Each channel now shows 2-3 clean rows (credentials, channel-specific status, guardian) with inline editing on demand. - Extract channels tab into SettingsChannelsTab.swift with reusable channelStatusRow helper for consistent Label | Status | Action layout - Remove setup-oriented UI (manual phone assign, provision, refresh) — initial setup is handled conversationally by the assistant - SMS phone number changes via expandable number picker with auto-fetch - Delete dead SettingsView.swift (~1200 lines) and update tests - Update stale comments referencing removed SettingsView Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0371006055
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #7175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsChannelsTab.swiftwith reusablechannelStatusRowhelper; removed setup-oriented UI (manual phone assign, area code + provision, refresh button) since initial setup is handled conversationallySettingsView.swift(~1200 lines), updated 3 test files to use direct store access, cleaned up stale commentsOriginal prompt
Simplify the channel settings UI to a status-first display optimized for post-setup viewing and reconfiguration. Unify channel codepaths where possible.
🤖 Generated with Claude Code