fix: narrow QA intent detection + fix safety-net timer race#6978
Merged
Jasonnnz merged 1 commit intoFeb 23, 2026
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
10 tasks
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…6978) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from PR review feedback:
QA intent false positives: Removed 'check' from direct prefix regex and natural language patterns. 'check my email', 'check the weather' no longer trigger QA mode. Added 'check for bugs/errors/issues/regressions' as a narrow QA-specific pattern.
Safety-net timer race: The cancel safety-net task used try? to swallow CancellationError from Task.sleep, then checked self.isCancelled (always true after cancel()). When run() cancelled the task and yielded at await finalizeQARecording(), the safety-net could resume and send abort before finalization. Added guard !Task.isCancelled to properly respect task cancellation.