feat: wire QA recording captureScope and includeAudio config#6967
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2c49c8c63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if qaMode, let recorder = screenRecorder { | ||
| do { | ||
| try await recorder.startRecording(windowID: nil, displayID: nil, includeAudio: false) | ||
| try await recorder.startRecording(windowID: nil, displayID: nil, includeAudio: self.includeAudio) |
There was a problem hiding this comment.
When qaRecording.captureScope is set to "window", this call still passes windowID: nil and displayID: nil, so ScreenRecorder.startRecording always takes its display fallback path and records the full display. That makes the new captureScope config effectively a no-op for all QA sessions, which will surprise anyone enabling window-only capture and can invalidate QA recording expectations.
Useful? React with 👍 / 👎.
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…#6967) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
captureScope(window|display) andincludeAudiofields toQaRecordingConfigSchemaand defaultsTaskRoutedIPC message to the macOS clientSession.swiftnow readsincludeAudiofrom config instead of hardcodedfalsecaptureScopeis stored on the session for metadata consistencyretentionDaysTest plan
bunx tsc --noEmit)qaRecording.includeAudio: truein config and verify audio is captured in QA recordingsqaRecording.captureScope: "window"in config and verify it flows through to session metadata🤖 Generated with Claude Code