Skip to content

Wire QA mode in macOS client: create recorder when daemon signals QA intent #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 23, 2026
+8 −2
Merged

Wire QA mode in macOS client: create recorder when daemon signals QA intent #6945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions clients/macos/vellum-assistant/App/AppDelegate+Sessions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ extension AppDelegate {
maxSteps: maxSteps,
sessionId: routed.sessionId,
skipSessionCreate: true,
notificationService: self.services.activityNotificationService
notificationService: self.services.activityNotificationService,
screenRecorder: (routed.qaMode == true) ? ScreenRecorder() : nil,
reportToSessionId: routed.reportToSessionId,
qaMode: routed.qaMode ?? false
)
// Don't bind relatedViewModel for escalated sessions — the active view model
// may be unrelated if the user switched threads. Tool calls for escalated
Expand Down Expand Up @@ -193,7 +196,10 @@ extension AppDelegate {
attachments: submission.attachments,
sessionId: routed.sessionId,
skipSessionCreate: true,
notificationService: self.services.activityNotificationService
notificationService: self.services.activityNotificationService,
screenRecorder: (routed.qaMode == true) ? ScreenRecorder() : nil,
reportToSessionId: routed.reportToSessionId,
qaMode: routed.qaMode ?? false
)
// Don't bind relatedViewModel — sessions started via startSession() don't
// originate from a chat thread, so there's no ChatViewModel to extract
Expand Down