Skip to content

M5: Retention Cleanup + Tests + Documentation#6919

Merged
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/qa-video-auto/task-8
Feb 23, 2026
Merged

M5: Retention Cleanup + Tests + Documentation#6919
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/qa-video-auto/task-8

Conversation

@Jasonnnz
Copy link
Copy Markdown
Contributor

@Jasonnnz Jasonnnz commented Feb 23, 2026

Adds qaRecording config section, periodic cleanup worker for expired file-backed recordings, ARCHITECTURE.md documentation for QA video data flow, and cleanup tests. Part of #6899.

Changes

Config (qaRecording section)

  • defaultRetentionDays (default: 7) — how long recordings are kept
  • cleanupIntervalMs (default: 6 hours) — how often the cleanup worker runs

Cleanup worker (recording-cleanup.ts)

  • Runs one pass on daemon startup to catch recordings that expired while offline
  • Runs periodically on the configured interval
  • For each expired file-backed attachment: deletes file from disk, removes DB row, logs summary
  • Wired into lifecycle.ts init/shutdown

Tests (recording-cleanup.test.ts)

  • Expired file-backed attachments are cleaned up (files deleted, DB rows removed)
  • Non-expired attachments are NOT cleaned up
  • Inline base64 attachments are never touched by cleanup
  • Missing files handled gracefully
  • Multiple expired recordings cleaned in one pass
  • File-backed attachments without expiresAt are never cleaned

Architecture docs

  • QA Recording data flow section added
  • File-backed attachment storage table
  • Retention cleanup documentation
  • Storage Summary table updated with file-backed attachment row

Open with Devin

@Jasonnnz Jasonnnz self-assigned this Feb 23, 2026
@Jasonnnz Jasonnnz merged commit 985ab09 into feature/qa-video-automation Feb 23, 2026
@Jasonnnz Jasonnnz deleted the swarm/qa-video-auto/task-8 branch February 23, 2026 16:27
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e569ee44e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/config/schema.ts
@Jasonnnz
Copy link
Copy Markdown
Contributor Author

Addressed in #6925

Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
… QA video (#6919)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant