Skip to content

Fix M3 feedback: legacy migration + RFC 7233 range clamping#6913

Merged
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/qa-video-auto/task-6
Feb 23, 2026
Merged

Fix M3 feedback: legacy migration + RFC 7233 range clamping#6913
Jasonnnz merged 1 commit into
feature/qa-video-automationfrom
swarm/qa-video-auto/task-6

Conversation

@Jasonnnz
Copy link
Copy Markdown
Contributor

@Jasonnnz Jasonnnz commented Feb 23, 2026

Summary

  • Adds storage_kind, file_path, sha256, and expires_at columns to the hardcoded attachments table rebuild in migrateRemoveAssistantIdColumns, so legacy databases preserve the new columns through the migration.
  • Clamps oversized byte-range end to fileSize - 1 per RFC 7233, instead of returning 416 for valid requests with an oversized end.
  • Adds test coverage for the range clamping behavior.

Part of #6899.

Test plan

  • TypeScript type-check passes
  • Attachment content route tests pass (8/8), including new clamping test

Open with Devin

…r RFC 7233

Co-Authored-By: Claude <noreply@anthropic.com>
@Jasonnnz Jasonnnz self-assigned this Feb 23, 2026
@Jasonnnz Jasonnnz merged commit 10212ad into feature/qa-video-automation Feb 23, 2026
@Jasonnnz Jasonnnz deleted the swarm/qa-video-auto/task-6 branch February 23, 2026 16:15
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/memory/db.ts
@Jasonnnz
Copy link
Copy Markdown
Contributor Author

Addressed in #6924

Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz added a commit that referenced this pull request Feb 23, 2026
…r RFC 7233 (#6913)

Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant