M2: Daemon Finalization Handler + CU Metadata Plumbing#6909
Merged
Conversation
…bing Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c88702d5e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #6912 |
10 tasks
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
Jasonnnz
added a commit
that referenced
this pull request
Feb 23, 2026
…bing (#6909) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the full cu_session_finalized handler: stores reportToSessionId and qaMode during CU session creation, injects QA summary into the originating chat session on finalization, cleans up session state. Part of #6899.
Changes
assistant/src/daemon/handlers/shared.ts: AddedCuSessionMetadatainterface andcuSessionMetadatamap toHandlerContextassistant/src/daemon/server.ts: AddedcuSessionMetadatamap instance and plumbed it intohandlerContext()assistant/src/daemon/handlers/computer-use.ts:reportToSessionIdandqaModefromCuSessionCreateinto metadata maphandleCuSessionFinalized: looks up metadata, persists assistant message in reporting session's conversation, streams summary to connected client viaassistant_text_delta+message_complete, logs recording metadata for M3, cleans up all CU session stateremoveCuSessionReferencesto clean up metadata mapassistant/src/daemon/handlers/index.ts: Re-exportedCuSessionMetadatatypeassistant/src/__tests__/cu-session-finalized.test.ts: New test file with 5 tests covering summary injection, cleanup, missing conversation handling, recording metadata, and metadata storagecuSessionMetadata: new Map()to HandlerContext mocks