-
Notifications
You must be signed in to change notification settings - Fork 87
fix: use manual code signing for iOS release archives #6042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,9 +128,10 @@ xcodebuild archive \ | |
| -destination 'generic/platform=iOS' \ | ||
| -archivePath "$ARCHIVE_PATH" \ | ||
| -configuration Release \ | ||
| -allowProvisioningUpdates \ | ||
| DEVELOPMENT_TEAM="$DEVELOPMENT_TEAM" \ | ||
| CODE_SIGN_STYLE=Automatic \ | ||
| CODE_SIGN_STYLE=Manual \ | ||
| CODE_SIGN_IDENTITY="Apple Distribution" \ | ||
| PROVISIONING_PROFILE_SPECIFIER="Vellum Assistant iOS Distribution" \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The archive step now hardcodes Useful? React with πΒ / π. |
||
| MARKETING_VERSION="$DISPLAY_VERSION" \ | ||
| CURRENT_PROJECT_VERSION="$BUILD_VERSION" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π΄ exportOptions.plist signingStyle still set to 'automatic' after switching archive to manual signing
The archive step was switched to
CODE_SIGN_STYLE=Manual(line 132), but the dynamically generatedexportOptions.plistat line 172 still specifies<key>signingStyle</key><string>automatic</string>. This mismatch meansxcodebuild -exportArchivewill attempt automatic signing during the export phase, which contradicts the manual signing used during archiving.Root Cause and Impact
When
signingStyleisautomaticin the export options,xcodebuild -exportArchivetries to automatically resolve signing identities and provisioning profiles. Since the archive was built with manual signing using a specificPROVISIONING_PROFILE_SPECIFIER="Vellum Assistant iOS Distribution", the export step should also use manual signing with matchingprovisioningProfilesdictionary.The
exportOptions.plistshould be updated to:Without this, the export may fail with a signing error, or it may re-sign with a different (wrong) profile, defeating the purpose of the manual signing change.
(Refers to line 172)
Prompt for agents
Was this helpful? React with π or π to provide feedback.