Skip to content

fix: prevent document editor panel closing on second show; close document on panel dismiss #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinatrajk merged 1 commit into from
Feb 19, 2026
Merged

fix: prevent document editor panel closing on second show; close document on panel dismiss #4821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/macos/vellum-assistant/Features/MainWindow/MainWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ final class MainWindow {
initialContent: msg.initialContent
)
show()
windowState.togglePanel(.documentEditor)
windowState.selection = .panel(.documentEditor)
}

func handleDocumentEditorUpdate(_ msg: DocumentEditorUpdateMessage) {
Expand All @@ -189,7 +189,7 @@ final class MainWindow {
initialContent: content
)
show()
windowState.togglePanel(.documentEditor)
windowState.selection = .panel(.documentEditor)
}

func show() {
Expand Down
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/Features/MainWindow/MainWindowView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,7 @@ struct MainWindowView: View {
DocumentEditorPanelView(
documentManager: documentManager,
daemonClient: daemonClient,
onClose: { windowState.selection = nil }
onClose: { windowState.selection = nil; documentManager.closeDocument() }

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve unsaved edits when dismissing document panel

Calling documentManager.closeDocument() inside the panel close handler turns a UI dismiss action into a hard document reset, which clears currentContent/initialContent and cancels pending saves in DocumentManager.closeDocument(). In the common flow where a user types in the editor but has not clicked Save yet, closing and reopening the panel now drops those local edits and reloads only daemon-backed content, causing silent data loss that did not happen when close only hid the panel.

Useful? React with 👍 / 👎.

)
}
)
Expand Down