Skip to content

feat: theme-aware RTE (light/dark mode via CSS variables) #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinatrajk merged 1 commit into from
Feb 18, 2026
Merged

feat: theme-aware RTE (light/dark mode via CSS variables) #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 47 additions & 20 deletions assistant/src/tools/document/editor-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,41 @@ export function generateEditorHTML(title: string, initialContent: string): strin

<!-- Toast UI Editor CSS -->
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/toastui-editor.min.css" />
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/theme/toastui-editor-dark.min.css" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github-dark.min.css" />
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/theme/toastui-editor-dark.min.css"
media="(prefers-color-scheme: dark)" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github-dark.min.css"
media="(prefers-color-scheme: dark)" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github.min.css"
media="(prefers-color-scheme: light)" />

<style>
:root {
--v-bg: #FFFFFF;
--v-surface: #F5F5F7;
--v-surface-border: #D2D2D7;
--v-text: #1D1D1F;
--v-text-secondary: #86868B;
--v-text-muted: #AEAEB2;
--v-accent: #8A5BE0;
}
@media (prefers-color-scheme: dark) {
:root {
--v-bg: #070D19;
--v-surface: #1E293B;
--v-surface-border: #334155;
--v-text: #F8FAFC;
--v-text-secondary: #94A3B8;
--v-text-muted: #64748B;
--v-accent: #8A5BE0;
}
}

* { margin: 0; padding: 0; box-sizing: border-box; }

body {
font-family: -apple-system, BlinkMacSystemFont, "SF Pro Text", "Helvetica Neue", sans-serif;
background: #0f172a;
color: #f8fafc;
background: var(--v-bg);
color: var(--v-text);
height: 100vh;
display: flex;
flex-direction: column;
Expand All @@ -39,7 +64,7 @@ export function generateEditorHTML(title: string, initialContent: string): strin

.header {
padding: 16px 24px;
border-bottom: 1px solid #334155;
border-bottom: 1px solid var(--v-surface-border);
display: flex;
align-items: center;
justify-content: space-between;
Expand All @@ -51,17 +76,17 @@ export function generateEditorHTML(title: string, initialContent: string): strin
font-weight: 600;
background: transparent;
border: none;
color: #f8fafc;
color: var(--v-text);
outline: none;
flex: 1;
min-width: 0;
}

.title-input::placeholder { color: #64748b; }
.title-input::placeholder { color: var(--v-text-muted); }

.status {
font-size: 12px;
color: #94a3b8;
color: var(--v-text-secondary);
margin-left: 16px;
white-space: nowrap;
}
Expand All @@ -76,22 +101,22 @@ export function generateEditorHTML(title: string, initialContent: string): strin
height: 100%;
}

/* Override Toast UI Editor dark theme colors to match Vellum */
/* Override Toast UI Editor theme colors to match Vellum */
.toastui-editor-defaultUI { border: none !important; }
.toastui-editor-toolbar { background: #1e293b !important; border-bottom: 1px solid #334155 !important; }
.toastui-editor-toolbar-icons { color: #cbd5e1 !important; }
.toastui-editor-toolbar-icons:hover { background: #334155 !important; }
.toastui-editor-toolbar { background: var(--v-surface) !important; border-bottom: 1px solid var(--v-surface-border) !important; }
.toastui-editor-toolbar-icons { color: var(--v-text-secondary) !important; }
.toastui-editor-toolbar-icons:hover { background: var(--v-surface-border) !important; }
.toastui-editor-md-container,
.toastui-editor-ww-container { background: #0f172a !important; color: #f8fafc !important; }
.toastui-editor-contents { color: #f8fafc !important; }
.toastui-editor-ww-container { background: var(--v-bg) !important; color: var(--v-text) !important; }
.toastui-editor-contents { color: var(--v-text) !important; }
.toastui-editor-contents h1,
.toastui-editor-contents h2,
.toastui-editor-contents h3 { color: #f8fafc !important; border-bottom-color: #334155 !important; }
.toastui-editor-contents pre { background: #1e293b !important; }
.toastui-editor-contents code { background: #1e293b !important; color: #e2e8f0 !important; }
.toastui-editor-contents blockquote { border-left-color: #7c3aed !important; color: #cbd5e1 !important; }
.toastui-editor-contents h3 { color: var(--v-text) !important; border-bottom-color: var(--v-surface-border) !important; }
.toastui-editor-contents pre { background: var(--v-surface) !important; }
.toastui-editor-contents code { background: var(--v-surface) !important; color: var(--v-text) !important; }
.toastui-editor-contents blockquote { border-left-color: var(--v-accent) !important; color: var(--v-text-secondary) !important; }
.toastui-editor-contents table td,
.toastui-editor-contents table th { border-color: #334155 !important; }
.toastui-editor-contents table th { border-color: var(--v-surface-border) !important; }
</style>
</head>
<body>
Expand All @@ -109,12 +134,14 @@ export function generateEditorHTML(title: string, initialContent: string): strin

<script>
// Initialize Toast UI Editor
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;

const editor = new toastui.Editor({
el: document.querySelector('#editor'),
height: '100%',
initialEditType: 'wysiwyg',
previewStyle: 'vertical',
theme: 'dark',
theme: prefersDark ? 'dark' : 'light',
usageStatistics: false,
initialValue: ${JSON.stringify(initialContent)},
toolbarItems: [
Expand Down
67 changes: 47 additions & 20 deletions clients/macos/vellum-assistant/Features/MainWindow/DocumentEditorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,16 +210,41 @@ private func generateEditorHTML(title: String, initialContent: String) -> String

<!-- Toast UI Editor CSS -->
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/toastui-editor.min.css" />
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/theme/toastui-editor-dark.min.css" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github-dark.min.css" />
<link rel="stylesheet" href="https://uicdn.toast.com/editor/latest/theme/toastui-editor-dark.min.css"
media="(prefers-color-scheme: dark)" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github-dark.min.css"
media="(prefers-color-scheme: dark)" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/github.min.css"
media="(prefers-color-scheme: light)" />

<style>
:root {
--v-bg: #FFFFFF;
--v-surface: #F5F5F7;
--v-surface-border: #D2D2D7;
--v-text: #1D1D1F;
--v-text-secondary: #86868B;
--v-text-muted: #AEAEB2;
--v-accent: #8A5BE0;
}
@media (prefers-color-scheme: dark) {
:root {
--v-bg: #070D19;
--v-surface: #1E293B;
--v-surface-border: #334155;
--v-text: #F8FAFC;
--v-text-secondary: #94A3B8;
--v-text-muted: #64748B;
--v-accent: #8A5BE0;
}
}

* { margin: 0; padding: 0; box-sizing: border-box; }

body {
font-family: -apple-system, BlinkMacSystemFont, "SF Pro Text", "Helvetica Neue", sans-serif;
background: #0f172a;
color: #f8fafc;
background: var(--v-bg);
color: var(--v-text);
height: 100vh;
display: flex;
flex-direction: column;
Expand All @@ -228,7 +253,7 @@ private func generateEditorHTML(title: String, initialContent: String) -> String

.header {
padding: 16px 24px;
border-bottom: 1px solid #334155;
border-bottom: 1px solid var(--v-surface-border);
display: flex;
align-items: center;
justify-content: space-between;
Expand All @@ -240,17 +265,17 @@ private func generateEditorHTML(title: String, initialContent: String) -> String
font-weight: 600;
background: transparent;
border: none;
color: #f8fafc;
color: var(--v-text);
outline: none;
flex: 1;
min-width: 0;
}

.title-input::placeholder { color: #64748b; }
.title-input::placeholder { color: var(--v-text-muted); }

.status {
font-size: 12px;
color: #94a3b8;
color: var(--v-text-secondary);
margin-left: 16px;
white-space: nowrap;
}
Expand All @@ -265,22 +290,22 @@ private func generateEditorHTML(title: String, initialContent: String) -> String
height: 100%;
}

/* Override Toast UI Editor dark theme colors to match Vellum */
/* Override Toast UI Editor theme colors to match Vellum */
.toastui-editor-defaultUI { border: none !important; }
.toastui-editor-toolbar { background: #1e293b !important; border-bottom: 1px solid #334155 !important; }
.toastui-editor-toolbar-icons { color: #cbd5e1 !important; }
.toastui-editor-toolbar-icons:hover { background: #334155 !important; }
.toastui-editor-toolbar { background: var(--v-surface) !important; border-bottom: 1px solid var(--v-surface-border) !important; }
.toastui-editor-toolbar-icons { color: var(--v-text-secondary) !important; }
.toastui-editor-toolbar-icons:hover { background: var(--v-surface-border) !important; }
.toastui-editor-md-container,
.toastui-editor-ww-container { background: #0f172a !important; color: #f8fafc !important; }
.toastui-editor-contents { color: #f8fafc !important; }
.toastui-editor-ww-container { background: var(--v-bg) !important; color: var(--v-text) !important; }
.toastui-editor-contents { color: var(--v-text) !important; }
.toastui-editor-contents h1,
.toastui-editor-contents h2,
.toastui-editor-contents h3 { color: #f8fafc !important; border-bottom-color: #334155 !important; }
.toastui-editor-contents pre { background: #1e293b !important; }
.toastui-editor-contents code { background: #1e293b !important; color: #e2e8f0 !important; }
.toastui-editor-contents blockquote { border-left-color: #7c3aed !important; color: #cbd5e1 !important; }
.toastui-editor-contents h3 { color: var(--v-text) !important; border-bottom-color: var(--v-surface-border) !important; }
.toastui-editor-contents pre { background: var(--v-surface) !important; }
.toastui-editor-contents code { background: var(--v-surface) !important; color: var(--v-text) !important; }
.toastui-editor-contents blockquote { border-left-color: var(--v-accent) !important; color: var(--v-text-secondary) !important; }
.toastui-editor-contents table td,
.toastui-editor-contents table th { border-color: #334155 !important; }
.toastui-editor-contents table th { border-color: var(--v-surface-border) !important; }
</style>
</head>
<body>
Expand All @@ -298,12 +323,14 @@ private func generateEditorHTML(title: String, initialContent: String) -> String

<script>
// Initialize Toast UI Editor
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;

window.editor = new toastui.Editor({
el: document.querySelector('#editor'),
height: '100%',
initialEditType: 'wysiwyg',
previewStyle: 'vertical',
theme: 'dark',
theme: prefersDark ? 'dark' : 'light',
usageStatistics: false,
initialValue: \(escapedContent),
toolbarItems: [
Expand Down
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/Features/MainWindow/MainWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ final class MainWindow {
initialContent: msg.initialContent
)
show()
windowState.selection = .panel(.documentEditor)
windowState.togglePanel(.documentEditor)
Comment thread
marinatrajk marked this conversation as resolved.
}

func handleDocumentEditorUpdate(_ msg: DocumentEditorUpdateMessage) {
Expand Down
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/Features/MainWindow/MainWindowView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ struct MainWindowView: View {
DocumentEditorPanelView(
documentManager: documentManager,
daemonClient: daemonClient,
onClose: { windowState.selection = nil; documentManager.closeDocument() }
onClose: { windowState.selection = nil }
Comment thread
marinatrajk marked this conversation as resolved.
Comment thread
marinatrajk marked this conversation as resolved.
)
}
)
Expand Down
Loading