fix: wire document editor so RTE appears when assistant opens it#4502
Merged
marinatrajk merged 1 commit intoFeb 18, 2026
Merged
Conversation
…eate Co-Authored-By: Claude <noreply@anthropic.com>
marinatrajk
deleted the
marinatrajkovska/fix-rte-document-editor-wiring
branch
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e34fa26ffc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
marinatrajk
added a commit
that referenced
this pull request
Feb 18, 2026
…ment on panel dismiss Address review feedback on PR #4502: - Replace togglePanel(.documentEditor) with direct selection assignment to avoid accidentally closing the panel when a second document_editor_show message arrives while the panel is already open - Call documentManager.closeDocument() when closing the document editor panel to reset stale editorCoordinator state Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
marinatrajk
added a commit
that referenced
this pull request
Feb 18, 2026
…ment on panel dismiss (#4578) Address review feedback on PR #4502: - Replace togglePanel(.documentEditor) with direct selection assignment to avoid accidentally closing the panel when a second document_editor_show message arrives while the panel is already open - Call documentManager.closeDocument() when closing the document editor panel to reset stale editorCoordinator state Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
Addressed in #4578 |
marinatrajk
pushed a commit
that referenced
this pull request
Feb 19, 2026
…ment on panel dismiss Address review feedback on PR #4502: - Replace togglePanel(.documentEditor) with direct selection assignment to avoid accidentally closing the panel when a second document_editor_show or document_load_response message arrives while the panel is already open - Call documentManager.closeDocument() when closing the document editor panel to reset stale editorCoordinator state, ensuring reopened documents load correctly Co-Authored-By: Claude <noreply@anthropic.com>
Merged
4 tasks
marinatrajk
added a commit
that referenced
this pull request
Feb 19, 2026
…ment on panel dismiss (#4821) Address review feedback on PR #4502: - Replace togglePanel(.documentEditor) with direct selection assignment to avoid accidentally closing the panel when a second document_editor_show or document_load_response message arrives while the panel is already open - Call documentManager.closeDocument() when closing the document editor panel to reset stale editorCoordinator state, ensuring reopened documents load correctly Co-authored-by: marinatrajk <marina@odyseek.com> Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
Addressed in #4821 |
marinatrajk
added a commit
that referenced
this pull request
Feb 19, 2026
…ment on panel dismiss (#4822) Address review feedback on PR #4502: - Replace togglePanel(.documentEditor) with direct selection assignment to avoid accidentally closing the panel when a second document_editor_show or document_load_response message arrives while the panel is already open - Call documentManager.closeDocument() when closing the document editor panel to reset stale editorCoordinator state, ensuring reopened documents load correctly Co-authored-by: marinatrajk <marina@odyseek.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDocumentEditorShow,onDocumentEditorUpdate,onDocumentSaveResponsedaemon callbacks inAppDelegate.setupDaemonClient()— previously these were defined but never wired, so messages were silently droppedDocumentManagertoMainWindowand handler methods that callcreateDocument/updateDocument/handleSaveResponseand toggle the new.documentEditorpanel.documentEditorcase toSidePanelTypeand renderDocumentEditorPanelViewas a VSplitView side panel inMainWindowViewDocumentEditorPanelViewwith a header toolbar (title, save, close) wrappingDocumentEditorView🤖 Generated with Claude Code