fix: filter auth_result in sendOneMessage after authentication#3521
Merged
Conversation
When hasSocketOverride() is enabled, the server auto-authenticates and sends an auth_result. If the client also sends an auth message (because it has a local token), the server responds with a second auth_result. After the first auth_result sets authenticated=true, the second one falls through to the response handler and gets resolved as the command response, breaking CLI subcommands. Filter auth_result messages in the authenticated path of sendOneMessage, matching the existing pattern for daemon_status and session_info. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
hasSocketOverride()is enabled, the server auto-authenticates the socket and sends anauth_result. If the client also sends anauthmessage (because it has a local token), the server responds with a secondauth_result. After the firstauth_resultsetsauthenticated = true, the second one falls through to the response handler insendOneMessageand gets resolved as the command response — breaking all CLI subcommands (sessions list,session_create, etc.) in forwarded-socket environments.Fix: Filter
auth_resultmessages in the authenticated path ofsendOneMessage, matching the existing pattern fordaemon_statusandsession_info.Addresses feedback from Codex and Devin on #3440.