fix: auto-authenticate clients on overridden socket paths#3431
Merged
Conversation
When VELLUM_DAEMON_SOCKET is set (e.g. SSH-forwarded sockets), the CLI skips sending an auth message if no local session token is found. But the server had no corresponding logic — it always required auth within 5 seconds, causing an infinite reconnect loop. Now the server detects hasSocketOverride() and auto-authenticates incoming connections on the overridden path. Clients that DO have a token still send auth normally and it's harmlessly ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
siddseethepalli
force-pushed
the
swarm/task-3
branch
from
4eb7396 to
c55ca72
Compare
3 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c55ca725d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
Addressed in #3440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
VELLUM_DAEMON_SOCKETis set (e.g. SSH-forwarded sockets), the CLI skips sending anauthmessage if no local session token is found. However, the server had no corresponding logic — it always required auth within 5 seconds (AUTH_TIMEOUT_MS), causing an infinite reconnect loop.This fix adds server-side detection of
hasSocketOverride()inhandleConnection. When true, incoming connections are auto-authenticated immediately, bypassing the auth timeout. Clients that DO have a token still sendauthnormally, and the message is harmlessly ignored since the socket is already authenticated.Modified files:
assistant/src/daemon/server.ts— importhasSocketOverride, auto-authenticate inhandleConnectionAddresses feedback from codex and devin on #3410.