Skip to content

PR #32631 followup: ToolDefinition = z.infer<>, kill double factory #32683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvargasfuertes merged 1 commit into from
May 30, 2026
Merged

PR #32631 followup: ToolDefinition = z.infer<>, kill double factory #32683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions assistant/src/ipc/skill-routes/registries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,10 @@ async function handleRegisterTools(

// Finalize before branching so both the supervisor short-circuit and
// the in-memory registration path see a `Tool[]` with guaranteed
// `name`. Skills run `finalizeTool` locally before sending, so the
// `?? ""` is a defensive empty-string default — `registerSkillTools`
// will reject an empty name on the non-supervisor path with a clear
// error. The execute closure arrives as a no-op error closure from
// `name`. The execute closure arrives as a no-op error closure from
// `finalizeTool`; the production (supervisor) path replaces it with
// the dispatching closure installed by the manifest loader at boot.
const proxies = tools.map((tool) => finalizeTool(tool, tool.name ?? ""));
const proxies = tools.map((t) => finalizeTool(t));

// Supervisor short-circuit: when a supervisor is registered, the
// manifest loader has already installed proxy tools at daemon boot.
Expand Down
Loading
Loading