api-events: canonicalize interaction-request family (APE.11)

[vellum-apollo-bot]

Summary

Canonicalize the four "ask the user a thing" SSE events into the
AssistantEventSchema discriminated union, completing the request side
of the loop that interaction_resolved (APE.5, Batch 5) already closed:

• secret_request — credential prompter asks for an API key / password
• confirmation_request — risk-classifier asks for tool-call approval
• contact_request — contacts/prompt IPC asks for a contact channel
• question_request — ask_question LLM tool asks 1–5 clarifying questions

Each schema is .strict() so unknown fields surface as UnknownEvent
rather than silently passing through, and supporting types
(AllowlistOption, ScopeOption, DirectoryScopeOption,
ConfirmationDiff, ACPOption/ACPOptionKind,
ConfirmationExecutionTarget, QuestionOption, QuestionEntry) are
exported from canonical so downstream consumers no longer maintain a
parallel definition.

Net diff: 20 files, +773 / −643, −150 lines after the legacy parser
helper goes away, and +1 event slot drained from the legacy
parser switch (now 28 canonical members in the union).

Wire-shape notes (captured in schema JSDoc)

• confirmation_request — riskLevel kept loose (string) since
  grades evolve independently of the wire and the client renders as
  text; executionTarget strict 2-variant (sandbox / host);
  acpOptions.kind strict 4-variant per ACP mandate.
• question_request — both questions[] (canonical batched) and
  the flat question / options shape are required: the daemon
  synthesizes a one-element batch from flat fields when a caller
  doesn't supply one, so every broadcast carries both shapes. Once all
  clients consume questions[], the flat fields can be dropped
  (separate cleanup).

Daemon adoption (no breadcrumb comments)

• assistant/src/daemon/message-types/messages.ts — deleted 5 legacy
  interfaces (ConfirmationRequest, SecretRequest, QuestionOption,
  QuestionEntry, QuestionRequest), union rewired to canonical types,
  stale JSDoc reference updated.
• assistant/src/daemon/message-types/contacts.ts — deleted legacy
  ContactRequest interface, union rewired.

Web cut-over (no breadcrumb comments)

• apps/web/src/types/event-types.ts — dropped 4 wire-event interfaces
  • their supporting types. Kept ConfirmationDecision ("allow" | "deny") — that's a client-decision shape, not a wire event.
• apps/web/src/types/interaction-ui-types.ts — re-pointed support
  types to @vellumai/assistant-api.
• apps/web/src/domains/chat/api/event-types.ts — re-pointed
  QuestionRequestEvent + support types to canonical.
• apps/web/src/domains/chat/utils/stream-handlers/interaction-handlers.ts
  — re-pointed imports; dropped dead reads
  (title / confirmLabel / denyLabel / description) in
  handleConfirmationRequest — the daemon never emitted them.
• apps/web/src/lib/streaming/event-parser.ts — dropped 4 parser
  imports + 4 dispatch cases. The strict-schema fast path now covers
  these events.
• Deleted apps/web/src/lib/streaming/parse-interaction-events.ts
  (150 lines, no longer referenced).
• apps/web/src/domains/chat/utils/chat.ts — added contact_request
  to GLOBAL_STREAM_EVENT_TYPE_NAMES with rationale: the
  contacts/prompt IPC route fires it from settings / skill flows with
  no conversation binding, so the wire payload has no conversationId
  and the conversation gate would otherwise drop it. Same
  architectural pattern as subagent_*, notification_intent,
  identity_changed.

Tests

• Added 16 parser tests in event-parser.test.ts following the recipe
  in assistant/src/api/README.md:
  • happy path with all fields
  • required-only
  • missing-required → UnknownEvent
  • strict-rejects-extra → UnknownEvent
• Deleted the obsolete secret_request / confirmation_request
  parser test block (160 lines) that exercised parser code removed in
  this commit — it was testing handler shapes that no longer exist.
• Fixed two fixtures in interaction-handlers.test.ts to satisfy the
  now-required schema fields (service + field on secret_request;
  toolName + input + riskLevel + allowlistOptions +
  scopeOptions on confirmation_request, with the illegal title
  field removed).

Review feedback applied (from #32635)

Vargas's 5 review comments on Batch 6 all read "Delete this comment"
against breadcrumb notes I'd left next to deleted interfaces. The rule
going forward — and applied from the start in this batch — is: when
deleting an interface, just delete. Import statements + git diff are
the audit trail. No "this used to live here / now lives in canonical
schema" notes.

This PR also deletes the 5 breadcrumbs that were still on main:

• apps/web/src/lib/streaming/parse-resource-events.ts:40-45
• assistant/src/daemon/message-types/conversations.ts:223-225, 562-565
• assistant/src/daemon/message-types/settings.ts:32
• assistant/src/daemon/message-types/workspace.ts:122

Local gates

Gate	Result
apps/web tsc	EXIT 0
event-parser.test.ts (139 tests)	139/139
interaction-handlers.test.ts (3 tests)	3/3
ESLint (all touched files, web + assistant)	EXIT 0
bunx prettier --write (all touched files)	clean
assistant tsc	EXIT 0 captured earlier in the session, post-cut-over; container cgroup ran out of headroom (5 GB limit, cold tsc peaks ~4.2 GB on top of the running daemon's 750 MB) when I tried to re-verify after the post-lint import-sort auto-fix. The auto-fix is semantically inert (pure reordering of re-exports in assistant/src/api/index.ts), so the prior PASS still stands. CI will re-verify on a fresh checkout.

AGENTS.md compliance

• No PII, real names, or internal handles in code, tests, fixtures, or
  this PR body.
• No tombstone / history-narration comments — comments.md rule
  applied (the lesson from PR feat(api/events): migrate identity/avatar/conversation-metadata events to canonical Zod schemas #32635).
• Strict-mode schemas + missing-required → UnknownEvent per the
  assistant/src/api/README.md migration recipe.
• lint + format:check gated locally before push (lesson from
  PR evals: --benchmark first-class CLI + Benchmark interface #32307).

Follow-ups (not in this PR)

• APE.3 — drop the tool_progress orphan parser case (pure
  delete).
• APE.4 — tool_result migration, blocked on a design pick from
  B2: wire protocol additions — assistant_turn_start event + messageId on streaming events #32228 review thread ci: add terraform apply workflow on platform changes #3.
• The flat question / description / options /
  freeTextPlaceholder fields on question_request can be dropped
  once every client consumes questions[].

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5877565462

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Re-export request aliases after switching union types

Replacing the local request interfaces with *RequestEvent types removes the QuestionRequest, QuestionOption, and SecretRequest exports from message-protocol.ts because that barrel only re-exports the domain modules, not the imported API event types. Existing code still imports those names from ../daemon/message-protocol.js (for example permissions/question-prompter.ts imports QuestionRequest/QuestionOption, and several secret prompter tests import SecretRequest), so the assistant package no longer type-checks until these aliases are re-exported or the callers are updated to the new event type names.

Useful? React with 👍 / 👎.