-
Notifications
You must be signed in to change notification settings - Fork 98
fix(ios): plant Django session cookie natively so it survives cold reopen #32410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f39a0d6
fix(ios): plant Django session cookie natively so it survives cold re…
clopen-set 0dff388
fix(ios): read session cookie natively when enabling biometrics mid-s…
clopen-set b8d8000
fix(ios): prefer __Secure-sessionid over bare sessionid when reading …
clopen-set File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import Foundation | ||
| import WebKit | ||
|
|
||
| /// Plants the server session cookie into WKWebView's `WKHTTPCookieStore` | ||
| /// after a native auth or biometric-recovery flow returns a session token. | ||
| /// | ||
| /// Lives on the native side because `document.cookie` in JS (a) cannot set | ||
| /// `HttpOnly`, (b) flushes async into WKWebView's store (race against the | ||
| /// next navigation), and (c) cannot set a `Max-Age` that the WKWebView | ||
| /// will honor across cold launches — the previous JS path produced a | ||
| /// session-only cookie that disappeared every time the app was killed. | ||
| enum SessionCookieInstaller { | ||
| /// Two weeks. Matches the deployed backend's session lifetime. | ||
| private static let maxAgeSeconds = 1_209_600 | ||
|
|
||
| static func install( | ||
| token: String, | ||
| server: URL, | ||
| into webView: WKWebView, | ||
| completion: @escaping () -> Void | ||
| ) { | ||
| guard let host = server.host else { | ||
| completion() | ||
| return | ||
| } | ||
|
|
||
| // `__Secure-` is the deployed-env cookie name; bare `sessionid` | ||
| // is for the HTTP LAN-IP local dev loop, where the `__Secure-` | ||
| // prefix would be rejected by the browser. | ||
| let isSecure = server.scheme == "https" | ||
| let name = isSecure ? "__Secure-sessionid" : "sessionid" | ||
| let secureAttr = isSecure ? "; Secure" : "" | ||
| let setCookie = "\(name)=\(token); Domain=\(host); Path=/; Max-Age=\(maxAgeSeconds); HttpOnly; SameSite=Lax\(secureAttr)" | ||
|
clopen-set marked this conversation as resolved.
|
||
|
|
||
| // `HTTPCookie(properties:)` rejects `HttpOnly` and `SameSite` | ||
| // property keys, so parse a real `Set-Cookie` header instead. | ||
| guard let cookie = HTTPCookie.cookies( | ||
| withResponseHeaderFields: ["Set-Cookie": setCookie], | ||
| for: server | ||
| ).first else { | ||
| completion() | ||
| return | ||
| } | ||
|
|
||
| DispatchQueue.main.async { | ||
| webView.configuration.websiteDataStore.httpCookieStore | ||
| .setCookie(cookie, completionHandler: completion) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.