revert(ios): remove WKAppBoundDomains — breaks Capacitor bridge#32160
Closed
Jasonnnz wants to merge 8 commits into
Closed
revert(ios): remove WKAppBoundDomains — breaks Capacitor bridge#32160Jasonnnz wants to merge 8 commits into
Jasonnnz wants to merge 8 commits into
Conversation
…pp kills (#32147) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Vellum Assistant <assistant@vellum.ai>
…ssing (#32150) Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Vellum Assistant <assistant@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WKAppBoundDomains puts WKWebView into a restrictive mode that denies message handler and JavaScript injection access by default. This breaks the Capacitor native bridge (window.webkit.messageHandlers), causing Capacitor.isNativePlatform() to return false and rendering the web login form instead of the native ASWebAuthenticationSession flow. The other session persistence fixes (CapacitorCookies, biometric recovery) don't need app-bound domains. Reverts #32148. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 593343b8a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… recovery Export waitForNativeSessionCookie and call it after installSessionCookies in the biometric recovery path. WKWebView cookie writes can lag behind JS execution — the same polling wait used in startNativeLogin prevents a valid recovered token from being missed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
Contributor
Author
Keep waitForNativeSessionCookie import and call from our branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by a clean PR from main — the feature branch was already squash-merged, making this unmergeable. |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WKAppBoundDomainsfrom Info.plist (reverts fix(ios): add WKAppBoundDomains for reliable cookie persistence #32148)window.webkit.messageHandlersaccess, breaking the Capacitor native bridgeCapacitor.isNativePlatform()to returnfalse, which renders the web login form ("Continue with Google") instead of the nativeASWebAuthenticationSessionflowTest plan