-
Notifications
You must be signed in to change notification settings - Fork 79
fix(web): port homepage UI tweaks from platform #7421 (LUM-1726) #31321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ccd1c97
fix(web): port homepage UI tweaks from platform #7421 (LUM-1726)
claude d1ceab7
fix(web): address review feedback on homepage UI tweaks
claude 845ebf0
docs(web): document "don't carry upstream tech debt" migration policy
claude 3214339
docs(web): revert migration-policy section from AGENTS.md
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Stale activeFilter state can silently re-activate when categories reappear
The
effectiveFilterderived state atapps/web/src/domains/home/home-feed-list.tsx:39-42gracefully falls back tonullwhen the selected category disappears frompresentCategories. However, the underlyingactiveFilterReact state is never reset — it retains the old category. If that category later reappears (e.g., new items arrive),effectiveFilterwill snap back to the previously selected filter without user interaction. This is an edge case (requires dismissing all items of a category, then new items arriving in the same category), and could be seen as a feature ("sticky filter memory"), but it may surprise users. AuseEffectthat callssetActiveFilter(null)whenactiveFilteris not inpresentCategorieswould make the reset explicit.Was this helpful? React with 👍 or 👎 to provide feedback.