Skip to content

chore(gitignore): ignore .agents/skills shared symlinks#31083

Merged
velissa-ai merged 1 commit into
mainfrom
do/gitignore-agents-skills
May 19, 2026
Merged

chore(gitignore): ignore .agents/skills shared symlinks#31083
velissa-ai merged 1 commit into
mainfrom
do/gitignore-agents-skills

Conversation

@velissa-ai
Copy link
Copy Markdown
Collaborator

@velissa-ai velissa-ai commented May 19, 2026

Summary

  • Add `.agents/skills/*` to `.gitignore` with an explicit un-ignore for the only repo-local skill (`testing-design-library-storybook`), mirroring the `.claude/skills` pattern that's already in place.
  • Removes ~35 untracked symlinks from every worktree's `git status`, so the `.claude/ship` wrapper's `git add -A` no longer pulls them in and trips the generic-examples pre-commit hook on path strings.

Original prompt

Three previous /do agents (PRs #31080, #31081, #31082) each had to manually sidestep the `.claude/ship` script because its `git add -A` was staging worktree-mirrored `.agents/skills/*` symlinks, whose paths got rejected by the generic-examples pre-commit hook. Root cause: `.agents/skills/` is re-included by `!.agents/skills/` in `.gitignore` without a subsequent ignore-children rule, so every shared skill symlink shows up as untracked. The `.claude/skills` block already solves the same problem for its mirror; this PR copies that pattern to `.agents/skills`.


Open in Devin Review

Worktree creation mirrors the shared claude-skills repo into both
.claude/skills/ and .agents/skills/. .claude/skills/* is already
gitignored (with explicit un-ignores for repo-local skills), but
.agents/skills/* wasn't — so the 35-odd mirrored symlinks showed up as
untracked in every worktree, and the .claude/ship wrapper's blanket
git add -A swept them into commits, tripping the generic-examples
pre-commit hook on path strings.

Mirror the .claude/skills pattern: ignore .agents/skills/* and explicit
un-ignore for the one repo-local skill (testing-design-library-storybook).
@velissa-ai velissa-ai merged commit ae9692e into main May 19, 2026
@velissa-ai velissa-ai deleted the do/gitignore-agents-skills branch May 19, 2026 01:20
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant