Skip to content

test(cdp-inspect): de-flake ws-transport event fan-out #30397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvargasfuertes merged 1 commit into from
May 12, 2026
Merged

test(cdp-inspect): de-flake ws-transport event fan-out #30397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions assistant/src/tools/browser/cdp-client/cdp-inspect/__tests__/ws-transport.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,18 +249,22 @@ describe("connectCdpWsTransport", () => {
});

test("fans out events (frames with no id) to listeners", async () => {
// The server pushes the unsolicited event in direct response to
// a client trigger, sending the event frame BEFORE the response
// ack. WebSocket message ordering then guarantees the event
// arrives at the client (and is fanned out) before the trigger
// resolves — no setTimeout race between the server's open
// callback and the test attaching its listener.
const server = startFakeWsServer({
onOpen(ws) {
// Push an unsolicited event shortly after open.
setTimeout(() => {
ws.send(
JSON.stringify({
method: "Target.targetCreated",
params: { targetId: "abc" },
sessionId: "S1",
}),
);
}, 5);
onMessage(ws, frame) {
ws.send(
JSON.stringify({
method: "Target.targetCreated",
params: { targetId: "abc" },
sessionId: "S1",
}),
);
ws.send(JSON.stringify({ id: frame.id, result: {} }));
},
});
try {
Expand All @@ -273,8 +277,7 @@ describe("connectCdpWsTransport", () => {
transport.addEventListener((ev) => {
received.push(ev);
});
// Wait for the event to arrive.
await new Promise((r) => setTimeout(r, 50));
await transport.send("Test.trigger");
expect(received).toEqual([
{
method: "Target.targetCreated",
Expand Down
Loading