Skip to content

chore(assistant): trim contacts CLI per #30281 review (drop guardian-only help paragraph + remove contacts merge) #30301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvargasfuertes merged 1 commit into from
May 12, 2026
Merged

chore(assistant): trim contacts CLI per #30281 review (drop guardian-only help paragraph + remove contacts merge) #30301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions assistant/src/cli/commands/contacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,9 @@ can be linked to external identifiers — phone numbers,
Telegram IDs, email addresses — via channel memberships. The contact graph
is the source of truth for identity resolution across all channels.

Contact writes are guardian-only and happen through the assistant web UI
(Contacts tab) or the invite flow — there is no CLI command for creating
or updating contacts. This CLI exposes read, merge, and invite/channel
management only.

Examples:
$ assistant contacts list
$ assistant contacts get abc-123
$ assistant contacts merge keep-id merge-id
$ assistant contacts invites list`,
);

Expand Down Expand Up @@ -321,62 +315,6 @@ Examples:
}
});

// -----------------------------------------------------------------------
// merge
// -----------------------------------------------------------------------

contacts
.command("merge <keepId> <mergeId>")
.description("Merge two contacts")
.addHelpText(
"after",
`
Arguments:
keepId UUID of the surviving contact that will absorb the other.
Run 'assistant contacts list' to find IDs.
mergeId UUID of the contact to be merged and deleted

All channel memberships, conversation history, and metadata from mergeId
are transferred to keepId. After the merge, mergeId is permanently deleted.
This operation is irreversible.

Examples:
$ assistant contacts merge 7a3b1c2d-4e5f-6789-abcd-ef0123456789 9f8e7d6c-5b4a-3210-fedc-ba9876543210
$ assistant contacts merge keep-id merge-id --json`,
)
.action(
async (
keepId: string,
mergeId: string,
_opts: unknown,
cmd: Command,
) => {
const r = await cliIpcCall<{
ok: boolean;
contact: ContactWithChannels;
}>("merge_contacts", {
body: { keepId, mergeId },
});

if (!r.ok)
return exitFromIpcResult(
r as { ok: false; error?: string; statusCode?: number },
cmd,
);

const { contact } = r.result!;
if (shouldOutputJson(cmd)) {
writeOutput(cmd, { ok: true, contact });
} else {
process.stdout.write(
`Merged ${mergeId} into ${keepId}\n` +
formatContactDetail(contact) +
"\n",
);
}
},
);

// -----------------------------------------------------------------------
// prompt
// -----------------------------------------------------------------------
Expand Down
2 changes: 0 additions & 2 deletions gateway/src/risk/command-registry/commands/assistant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const ASSISTANT_SUPPORTED_COMMAND_PATHS = [
"config validate-allowlist",
"contacts",
"contacts list",
"contacts merge",
"contacts get",
"contacts prompt",
"contacts channels",
Expand Down Expand Up @@ -377,7 +376,6 @@ const riskOverrides: AssistantRiskOverride[] = [
{ path: "channel-verification-sessions cancel", risk: "low" },
{ path: "channel-verification-sessions revoke", risk: "low" },
{ path: "config set", risk: "low" },
{ path: "contacts merge", risk: "medium" },
{ path: "contacts prompt", risk: "medium" },
{ path: "contacts channels update-status", risk: "medium" },
{ path: "contacts invites create", risk: "high" },
Expand Down
Loading