fix(gateway): add missing MCP route policy entries#30267
Merged
Conversation
The `ipc-route-policy-coverage.test.ts` lint asserts that every gateway-only daemon route has a matching IPC policy entry in `gateway/src/auth/ipc-route-policy.ts`. Three internal_mcp routes were missing - causing the test (and every PR's CI) to fail on main: - internal_mcp_add - internal_mcp_list - internal_mcp_remove All three follow the same shape as the existing internal_mcp_* entries (`internal.write` scope, `svc_gateway` service).
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds three missing entries to
gateway/src/auth/ipc-route-policy.ts:internal_mcp_addinternal_mcp_listinternal_mcp_removeAll three follow the same shape as the existing
internal_mcp_*entries (internal.writescope,svc_gatewayservice).Why
gateway/src/__tests__/ipc-route-policy-coverage.test.tsis a lint test that walks the daemon route source files and asserts every gateway-only route has a matching IPC policy entry. Three internal_mcp routes were missing — failing the test onmainand on every open PR's CI run.Verification
Previously failing 3 tests (
internal_mcp_add,internal_mcp_list,internal_mcp_remove) all green.Scope
3-line addition, no behavior change. Unblocks
Lint, Type Check & Teston all PRs touching files in scope.