test(cli): update domain tests for IPC transport#30248
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
noanflaherty
added a commit
that referenced
this pull request
May 11, 2026
After PRs #30238-#30248 landed, four Assistant Checks jobs went red on main: * Type Check — 27 errors: * 26 call sites pass a CliIpcCallResult<T> into exitFromIpcResult, whose parameter was typed { ok: false; ... }. TypeScript narrows r.ok inside if (!r.ok) but does not re-narrow the object as a whole when passed. Widen the parameter to { ok: boolean; ... } — runtime semantics are unchanged (the function only inspects error / statusCode). * 1 .map() error in oauth/providers.ts — IPC response was typed { providers: SerializedProvider[] } (camelCase) but the route returns snake_case Record<string, unknown>. Aligned the IPC type to the wire shape. * Lint — 4 auto-fixable simple-import-sort errors in conversations.ts, credentials.ts, runtime/routes/index.ts, runtime/routes/platform-routes.ts. Applied via bun run lint --fix. * OpenAPI Spec Check — openapi.yaml was stale per CI. After fixing the package-resolution issue locally and regenerating, on-disk yaml is byte-identical to generator output (no diff in this commit) — the generator + types are now in sync. * Test — route-policy coverage guard was fixed by #30250. Remaining test failures (oauth providers update etc.) will be re-evaluated after this fix lands; many were downstream of the type-check failure surfacing as import-resolution errors in test files. No wire-format or public-API changes. Co-authored-by: credence-the-bot[bot] <277301654+credence-the-bot[bot]@users.noreply.github.com> Co-authored-by: Noa Flaherty <noa@vellum.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cliIpcCall instead of VellumPlatformClient
still tried to connect to the real daemon socket
Follow-up fix for #30238.