fix(daemon): pass structured referencedBy in 409 conflict details#30236
Merged
Conversation
The HTTP adapter was dropping RouteError.details when building error
responses. Now passes err.details through to the standard error
envelope, and the delete handler includes { referencedBy: [...] } in
ConflictError details so the Swift conflict sheet can display them
without fragile message-string parsing.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConflictErrornow accepts optionaldetails— aligns with the baseRouteErrorconstructor that already supports iterr.details— previouslyhttpError()was called withouterr.details, so any structured payload on aRouteErrorwas silently dropped from the wire response{ referencedBy: [...] }in conflict details — the Swift client'sparseConflictRefs(merged in feat(macos): inference providers UI (Phase 2 PR-E) #30231) already checkserror.details.referencedByfirst, but the daemon wasn't sending itFollow-up to #30231 — these changes were pushed to the PR branch but the PR was merged before they landed.
Test plan
bun test src/runtime/routes/__tests__/inference-provider-connection-routes.test.ts— 28/28 pass (tests assert onmessageandinstanceof, unaffected by the additivedetailsfield)ConflictErrorcallers unaffected (detailsparameter is optional)🤖 Generated with Claude Code