chore(assistant): regenerate openapi.yaml for new bookmarks routes#30126
Merged
Conversation
Bookmarks routes (#30119/#30122) added new endpoints under /v1/bookmarks but assistant/openapi.yaml was not regenerated, causing the OpenAPI Spec Check job on main to fail. Also adds a SAFE_LINE_PATTERN to the secrets pre-commit hook for YAML schema property declarations (e.g. `clientSecret:` followed by a nested `type: string` on the next line), which exists in the spec since #29596 but was previously unrecognized by the hook.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e6f251917
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
Addressed in #30549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BookmarkStore#30119/feat(settings): register Bookmarks tab in sidebar (flag-gated) #30122) added new endpoints under/v1/bookmarks,/v1/bookmarks/{id}, and/v1/bookmarks/by-message/{messageId}butassistant/openapi.yamlwas not regenerated, so theOpenAPI Spec Checkjob onmainstarted failing (run 25594599225). Re-ranbun run generate:openapi— the diff is exactly the missing bookmark routes (162 insertions, 0 deletions).SAFE_LINE_PATTERNto.githooks/pre-commitfor YAML schema property declarations (clientSecret:followed by an indentedtype:on the next line). This false positive has been inopenapi.yamlsince fix(oauth): routeassistant oauth connect --callback-transport=gatewaythrough daemon IPC #29596; it was hitting the regenerated file because previous regeneration commits never had to round-trip through the local hook. Self-test still passes.Original prompt
Fix the failing
OpenAPI Spec Checkjob from CI run 25594599225 onmain. The job fails withopenapi.yaml is stale. Run: bun run generate:openapiafter the bookmarks routes landed without a regenerated spec. Goal: regenerate the spec and unblock CI onmain.