fix(app-control): validate app field type before case-fold#30089
Merged
Conversation
Codex P1 on PR #29592: non-start tool input is cast through 'as unknown as HostAppControlInput' without runtime validation in conversation-surfaces, so a malformed payload with a non-string 'app' (number, object, etc.) would throw a TypeError at requestedApp.toLowerCase() and abort the tool flow instead of returning a controlled isError response. Tighten the guard from a null-check to a typeof check so non-string values produce the same controlled rejection as a missing field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Codex P1 from #29592: non-start app-control tool input reaches
checkNonStartAuthorizationvia an uncheckedas unknown as HostAppControlInputcast (conversation-surfaces.ts:2067), so a non-stringapppayload would throwTypeErrorat.toLowerCase(). Replace the null-check with atypeof requestedApp !== 'string'guard so malformed input produces a controlledisErrorresponse.Devin's stop-ownership note is intentional/no-op (idempotent stop confirmed in #30086).