Skip to content

test(app-control): update stop test for idempotent no-proxy behavior #30086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
May 9, 2026
Merged

test(app-control): update stop test for idempotent no-proxy behavior #30086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions assistant/src/__tests__/conversation-surfaces-app-control.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,18 @@ describe("surfaceProxyResolver — app-control tool routing", () => {
proxy.dispose();
});

test("returns isError for app_control_stop when no proxy is attached", async () => {
test("app_control_stop succeeds idempotently when no proxy is attached", async () => {
// Stop is local-only and runs BEFORE the isAvailable() gate so a
// disconnected client cannot strand the singleton lock. With no proxy
// attached at all, it must still succeed as a no-op without dispatching.
const ctx = buildMockContext();

const result = await surfaceProxyResolver(ctx, "app_control_stop", {
tool: "stop",
});

expect(result.isError).toBe(true);
expect(result.content).toContain("not available");
expect(result.isError).toBe(false);
expect(result.content.toLowerCase()).toContain("stopped");
expect(sentMessages).toHaveLength(0);
});
});
Expand Down
Loading