fix(daemon): allow app_control_stop to run when client is disconnected#30079
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
siddseethepalli
added a commit
that referenced
this pull request
May 9, 2026
… no proxy attached (#30086) PR #30079 moved the app_control_stop short-circuit BEFORE the isAvailable() gate so a disconnected client cannot strand the singleton lock. After that change, stop succeeds as a no-op even when no proxy is attached, but this test still asserted the old isError behavior. Update the assertion to match the new contract (stop is idempotent). Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Contributor
Author
|
Already addressed by #30086 (merged 2026-05-09). The test at conversation-surfaces-app-control.test.ts:160-173 now asserts the new idempotent-success contract for app_control_stop when no proxy is attached. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_control_stopshort-circuit BEFORE theisAvailable()gate so a disconnected client cannot strand the singleton lock.stopis purely local cleanup (dispose proxy, clear conversation reference); it never round-trips to the client and shouldn't require an available one.Addresses Devin review feedback on #29340.