Skip to content

fix(tool-projection): replace PR cross-reference in divergence comment with inline rationale #29628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
credence-the-bot merged 1 commit into from
May 5, 2026
Merged

fix(tool-projection): replace PR cross-reference in divergence comment with inline rationale #29628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assistant/src/tools/host-filesystem/edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ class HostFileEditTool implements Tool {
// cross-client turn. On web/ios, the call must fail loudly rather
// than silently target the daemon container's filesystem.
// Note: this scoping deliberately differs from host_bash
// (host-shell.ts:239-247), which rejects unconditionally; see PR #29613
// review discussion for rationale.
// (host-shell.ts:239-247), which rejects unconditionally for any
// stale target_client_id regardless of transport.
if (
targetClientId != null &&
transportInterface != null &&
Expand Down
4 changes: 2 additions & 2 deletions assistant/src/tools/host-filesystem/read.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ class HostFileReadTool implements Tool {
// cross-client turn. On web/ios, the call must fail loudly rather
// than silently target the daemon container's filesystem.
// Note: this scoping deliberately differs from host_bash
// (host-shell.ts:239-247), which rejects unconditionally; see PR #29613
// review discussion for rationale.
// (host-shell.ts:239-247), which rejects unconditionally for any
// stale target_client_id regardless of transport.
if (
targetClientId != null &&
transportInterface != null &&
Expand Down
4 changes: 2 additions & 2 deletions assistant/src/tools/host-filesystem/transfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ class HostFileTransferTool implements Tool {
// turn. On web/ios, the call must fail loudly rather than silently
// target the daemon container's filesystem.
// Note: this scoping deliberately differs from host_bash
// (host-shell.ts:239-247), which rejects unconditionally; see PR #29613
// review discussion for rationale.
// (host-shell.ts:239-247), which rejects unconditionally for any
// stale target_client_id regardless of transport.
if (
targetClientId != null &&
context.transportInterface != null &&
Expand Down
4 changes: 2 additions & 2 deletions assistant/src/tools/host-filesystem/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ class HostFileWriteTool implements Tool {
// cross-client turn. On web/ios, the call must fail loudly rather
// than silently target the daemon container's filesystem.
// Note: this scoping deliberately differs from host_bash
// (host-shell.ts:239-247), which rejects unconditionally; see PR #29613
// review discussion for rationale.
// (host-shell.ts:239-247), which rejects unconditionally for any
// stale target_client_id regardless of transport.
if (
targetClientId != null &&
transportInterface != null &&
Expand Down
Loading