fix(auth): add route policy for memory/v2/concept-frequency#29626
Merged
Conversation
The memory/v2/concept-frequency debug endpoint was added in #29618 but no matching scope policy was registered, causing guard-tests.test.ts to fail in CI. Add settings.read (matches sibling read-only debug routes like concept-page and explain-similarity).
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Merged
5 tasks
siddseethepalli
added a commit
that referenced
this pull request
May 9, 2026
…30098) The endpoint memory/v2/fit-anisotropy:POST was registered twice in ACTOR_ENDPOINTS. Since registerPolicy uses policyRegistry.set(), the second call silently overwrote the first, making one entry dead code. Follow-up to #29626 review feedback from Devin. Co-authored-by: Vellum Assistant <assistant@vellum.ai>
Contributor
Author
|
Addressed Devin's duplicate-registration finding in follow-up #30098 (already merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory/v2/concept-frequency:POSTentry toroute-policy.tswithsettings.readscope (matches sibling read-only debug routes).guard-tests.test.tsfailure: "Endpoints dispatched in http-server.ts have no route policy in route-policy.ts: memory/v2/concept-frequency".Original prompt
--yolo Fix the specific CI issue in this failing job only: https://github.com/vellum-ai/vellum-assistant/actions/runs/25363413453/job/74368127577