fix: address PR #2957 feedback (panel, window min, flow version)#2961
Merged
Conversation
1. Handle collapsed generated panel: clear activePanel when .generated routes to fullWindowPanel but isDynamicExpanded is false, preventing a blank content area with no path back to chat. 2. Align window minimum size: update NSWindow contentMinSize from 500x400 to 800x600 to match MainWindowView's .frame(minWidth:minHeight:) constraint, preventing content clipping at small sizes. 3. Bump currentFlowVersion to 3: ensures users mid-onboarding on the old 8-step flow get properly reset to step 0 via the version migration mechanism. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes review feedback from PR #2957:
activePanelwhen.generatedis routed tofullWindowPanelbutisDynamicExpandedisfalse, preventing the main content area from going blank with no path back to chat.contentMinSize(was 500x400) withMainWindowView's.frame(minWidth: 800, minHeight: 600)constraint, preventing content clipping when users resize the window below the SwiftUI minimum.currentFlowVersionfrom 2 to 3 so users mid-onboarding on the old 8-step flow get properly reset to step 0 via the version migration mechanism.Test plan
isDynamicExpanded = falsewhileactivePanel == .generated) falls back to the chat view instead of showing a blank screen🤖 Generated with Claude Code