-
Notifications
You must be signed in to change notification settings - Fork 98
feat(host-proxy): add targetClientId support to HostFileProxy and HostProxyBase #29394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -627,11 +627,13 @@ function registerPendingInteraction( | |
| pendingInteractions.register(msg.requestId, { | ||
| conversationId, | ||
| kind: "host_file", | ||
| targetClientId, | ||
| }); | ||
| } else if (msg.type === "host_cu_request") { | ||
| pendingInteractions.register(msg.requestId, { | ||
| conversationId, | ||
| kind: "host_cu", | ||
| targetClientId, | ||
|
Comment on lines
632
to
+636
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The same targeting gap exists for CU: this change records Useful? React with 👍 / 👎. |
||
| }); | ||
| } else if (msg.type === "host_app_control_request") { | ||
| pendingInteractions.register(msg.requestId, { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that
host_file_requeststorestargetClientIdin pending interactions,/v1/host-file-resultshould verify the submitting client matches that target (ashost-bash-resultalready does).handleHostFileResultcurrently accepts any authenticated submitter with arequestId, so a different connected client can resolve a targeted file request and inject/override the result if it learns the ID.Useful? React with 👍 / 👎.