Skip to content

fix(computer-use): drop activity from core definitions to match TOOLS.json#29378

Merged
siddseethepalli merged 1 commit into
mainfrom
do/jarvis-fix-cu-manifest-regression-test
May 3, 2026
Merged

fix(computer-use): drop activity from core definitions to match TOOLS.json#29378
siddseethepalli merged 1 commit into
mainfrom
do/jarvis-fix-cu-manifest-regression-test

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

@siddseethepalli siddseethepalli commented May 3, 2026

Summary

  • PR refactor(skills): remove redundant per-tool activity field #29374 removed the redundant per-tool `activity` field from bundled-skill `TOOLS.json` but missed the parallel definitions in `assistant/src/tools/computer-use/definitions.ts`.
  • The orphaned `activity` properties caused `computer-use-skill-manifest-regression.test.ts > manifest input_schema matches core definitions` to fail in CI (job).
  • Drops the `activityProperty` constant and all 11 `activity:` entries from the core definitions so they match the manifest again.

Original prompt

--yolo Fix the specific CI issue in this failing job only: https://github.com/vellum-ai/vellum-assistant/actions/runs/25275619605/job/74105006539


Open in Devin Review

…itions

PR #29374 removed the per-tool activity field from bundled-skill TOOLS.json
but left it in assistant/src/tools/computer-use/definitions.ts. The result
was that computer-use-skill-manifest-regression.test.ts > 'manifest
input_schema matches core definitions' failed because the manifest no
longer carried activity but the core definitions still did. Drop the
field from the core definitions to restore parity with the manifest.
@siddseethepalli siddseethepalli merged commit 6a6ed3c into main May 3, 2026
@siddseethepalli siddseethepalli deleted the do/jarvis-fix-cu-manifest-regression-test branch May 3, 2026 09:45
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant