Skip to content

feat(host-bash-result): reject result submissions from non-targeted clients (403)#29317

Merged
credence-the-bot[bot] merged 2 commits into
Credence/targeted-host-proxyfrom
targeted-host-proxy/pr-7-result-route-client-binding
May 3, 2026
Merged

feat(host-bash-result): reject result submissions from non-targeted clients (403)#29317
credence-the-bot[bot] merged 2 commits into
Credence/targeted-host-proxyfrom
targeted-host-proxy/pr-7-result-route-client-binding

Conversation

@credence-the-bot
Copy link
Copy Markdown
Contributor

@credence-the-bot credence-the-bot Bot commented May 3, 2026

Summary

  • Read x-vellum-client-id from host-bash-result requests and validate it against the pending interaction's targetClientId
  • Reject with 403 when the submitting client doesn't match; 400 when the header is missing for targeted requests
  • Add extraHeaders support to GatewayHTTPClient.post() and send X-Vellum-Client-Id in postBashResult()

Part of plan: targeted-host-proxy.md (PR 7 of 8)


Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@credence-the-bot credence-the-bot Bot merged commit ccd6aa9 into Credence/targeted-host-proxy May 3, 2026
13 checks passed
@credence-the-bot credence-the-bot Bot deleted the targeted-host-proxy/pr-7-result-route-client-binding branch May 3, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants