Skip to content

refactor(memory-v2): drop dead skill scaffolding#28601

Merged
velissa-ai merged 2 commits into
mainfrom
run-plan/mem-v2-skills/fix-r1-4
Apr 28, 2026
Merged

refactor(memory-v2): drop dead skill scaffolding#28601
velissa-ai merged 2 commits into
mainfrom
run-plan/mem-v2-skills/fix-r1-4

Conversation

@velissa-ai
Copy link
Copy Markdown
Collaborator

@velissa-ai velissa-ai commented Apr 28, 2026

Summary

Cleanup of v2 skill autoinjection slop identified in plan review:

  • Drop unused Zod schemas in types.ts (SkillEntrySchema, SkillEmbeddingPayloadSchema/Type) — replace with plain TS interface.
  • Drop displayName from SkillEntry/cache/Qdrant payload — only content is consumed at render time.
  • Drop deleteSkillEmbedding (no production caller; skills are only removed via pruneSkillsExcept inside seed).
  • Internalize SkillQueryResult (only used inside skill-qdrant.ts).

Plan: memory-v2-skill-autoinjection.md (review fix #4)


Open in Devin Review

…s/fix-r1-4

# Conflicts:
#	assistant/src/memory/v2/__tests__/injection.test.ts
@velissa-ai velissa-ai merged commit 868956c into main Apr 28, 2026
10 of 12 checks passed
@velissa-ai velissa-ai deleted the run-plan/mem-v2-skills/fix-r1-4 branch April 28, 2026 10:12
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants