Skip to content

fix(llm-callsite): pass callSite in approval generators #26508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Apr 18, 2026
Merged

fix(llm-callsite): pass callSite in approval generators #26508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions assistant/src/config/schemas/llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ export const LLMCallSiteEnum = z.enum([
"notificationDecision",
"preferenceExtraction",
"guardianQuestionCopy",
"approvalCopy",
"approvalConversation",
Comment on lines +58 to +59
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 New call sites not seeded in latency-optimized migration 040

Migration 040-seed-latency-callsite-defaults.ts:66-74 seeds latency-optimized defaults (fast model, low effort, thinking disabled) for several background call sites including guardianQuestionCopy. The new approvalCopy and approvalConversation call sites are functionally similar (short approval-related LLM calls with tight timeouts of 5s and 8s respectively). Without migration entries, these new call sites fall through to llm.default (opus + max effort), which may be more expensive and slower than intended for what are essentially latency-sensitive background tasks. This isn't a bug per se — the code works correctly — but it may be an oversight given the migration's stated purpose of preventing exactly this cost/latency regression for background tasks.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"watchCommentary",
"watchSummary",
"interactionClassifier",
Expand Down
2 changes: 2 additions & 0 deletions assistant/src/daemon/approval-generators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export function createApprovalCopyGenerator(): ApprovalCopyGenerator {
{
config: {
max_tokens: options.maxTokens ?? APPROVAL_COPY_MAX_TOKENS,
callSite: "approvalCopy",
},
signal: AbortSignal.timeout(
options.timeoutMs ?? APPROVAL_COPY_TIMEOUT_MS,
Expand Down Expand Up @@ -173,6 +174,7 @@ export function createApprovalConversationGenerator(): ApprovalConversationGener
{
config: {
max_tokens: APPROVAL_CONVERSATION_MAX_TOKENS,
callSite: "approvalConversation",
},
signal: AbortSignal.timeout(APPROVAL_CONVERSATION_TIMEOUT_MS),
},
Expand Down
Loading