fix(macos): update inference selection tests to new llm.default API#26287
Merged
Conversation
… llm.default API The tests were added in #26251 against the old `setInferenceProvider` / `services.inference.provider` API. #26159 merged afterward renamed that API to `setLLMDefaultProvider` and moved the config path to `llm.default.provider`, leaving the tests unable to compile. Rename the calls and update the patch assertions to match the new shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsStoreManagedInferenceSelectionTests.swiftcalledstore.setInferenceProvider(...)and asserted on aservices.inference.providerpatch. Both were obsolete after Unify LLM call-site configuration under llm.{default,profiles,callSites} #26159 renamed the API tosetLLMDefaultProviderand moved the config path underllm.default.provider, and the macOS Tests CI job has been red since.setLLMDefaultProviderand inspectllm.default.providerin the mock patch payload. No production code changes.Original prompt
--yolo Fix the specific CI issue in this failing job only: https://github.com/vellum-ai/vellum-assistant/actions/runs/24594653274/job/71922248511