Skip to content

fix(macos): replace URLSession.bytes with delegate-driven stream to survive session invalidation #26281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devin-ai-integration wants to merge 1 commit into from
Closed

fix(macos): replace URLSession.bytes with delegate-driven stream to survive session invalidation #26281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions clients/shared/Network/EventStreamClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,12 @@ public final class EventStreamClient {

// A back-to-back call to `startSSEStream()` on the MainActor can
// cancel this task and invalidate `session` before it runs its
// first instruction. Calling `session.bytes(for:)` on an already
// invalidated session throws an ObjC NSGenericException from
// `-[__NSURLSessionLocal taskForClassInfo:]`, which is
// uncatchable in Swift and crashes the process with SIGABRT.
// Bail out before touching the session if we've been superseded.
// first instruction. Bail out cheaply when that's already visible
// so we don't build the request or hop off MainActor for nothing.
// `GatewayHTTPClient.stream` additionally wraps data-task creation
// in an ObjC `@try/@catch` trampoline, which is the authoritative
// defense against invalidation that lands after this guard but
// before `URLSession` creates the underlying task.
guard !Task.isCancelled, self.sseSession === session else { return }

do {
Expand Down
Loading