refactor: decouple browser identifiers, add --browser-mode CLI flag#26249
Conversation
…de CLI flag - Extract BROWSER_TOOL_NAMES and name-mapping helpers into a lightweight browser/identifiers.ts module so policy/classification consumers (permissions/defaults, workspace-policy, side-effects) no longer pull in the browser execution stack at import time. - Add shared --browser-mode <mode> option to the `assistant browser` command with enum validation (auto, extension, cdp-inspect, local), restoring parity with existing browser_* tool capabilities. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The backend's normalizeBrowserMode already accepts these compatibility aliases. Restricting the CLI to canonical values only would break parity for scripts migrating from tool-level browser_mode inputs.
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 similar comment
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
BROWSER_TOOL_NAMESand bidirectional name-mapping helpers into a lightweightbrowser/identifiers.tsmodule that only depends onbrowser/types.ts. Policy and classification modules (permissions/defaults,workspace-policy,tools/side-effects) now import from there instead ofbrowser/operations.ts, avoiding eager import of the browser execution stack in non-browser codepaths.--browser-mode <mode>option (withauto | extension | cdp-inspect | localenum validation) at theassistant browsercommand level, passing it through asbrowser_modein the IPC input. This restores parity with existingbrowser_*tools that support backend pinning for debugging/recovery.browser/operations.tsre-exports the identifier symbols for backwards compatibility with callers that haven't migrated.Original prompt
address the feedback left in #26235 (comment)