Skip to content

fix: stale comment and error message wording for wait_for_download #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noanflaherty merged 1 commit into from
Apr 17, 2026
Merged

fix: stale comment and error message wording for wait_for_download #26234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assistant/src/__tests__/browser-skill-endstate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ describe("browser skill migration end-state", () => {
);
expect(fs.existsSync(execPath)).toBe(true);
const content = fs.readFileSync(execPath, "utf-8");
// browser_wait_for_download uses a standalone wrapper that calls
// browserManager.waitForDownload() directly — no execute* function.
// browser_wait_for_download has no matching executeBrowser* function
// exported from browser-execution.ts — it is handled via operations.ts.
const TOOLS_WITH_EXECUTE_FN = BROWSER_TOOL_NAMES.filter(
(name) => name !== "browser_wait_for_download",
);
Expand Down
2 changes: 1 addition & 1 deletion assistant/src/browser/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ async function executeWaitForDownload(
if (mode !== "auto" && mode !== "local") {
return {
content:
`Error: wait_for_download does not support browser_mode "${mode}". ` +
`Error: browser_wait_for_download does not support browser_mode "${mode}". ` +
`File downloads require the local Playwright backend. ` +
`Use browser_mode "auto" or "local" instead.`,
isError: true,
Expand Down
Loading