-
Notifications
You must be signed in to change notification settings - Fork 93
calls: route the call agent loop through callSite: 'callAgent' #26123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -522,6 +522,11 @@ export async function startVoiceTurn( | |||||||||||||||||||
| // Note: tool_use_preview_start is intentionally not handled here. | ||||||||||||||||||||
| // Voice only reacts to the definitive tool_use_start event. | ||||||||||||||||||||
| }, | ||||||||||||||||||||
| // Route every voice-call agent loop turn through the unified | ||||||||||||||||||||
| // `llm.callSites.callAgent` resolver. PR 4 backfilled this entry | ||||||||||||||||||||
| // from the legacy `config.calls.model` setting, so existing | ||||||||||||||||||||
| // overrides continue to apply. | ||||||||||||||||||||
| { callSite: "callAgent" }, | ||||||||||||||||||||
|
Comment on lines
+525
to
+529
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Comment narrates history and references a PR, violating mandatory AGENTS.md comment rule The added comment on lines 525-528 says
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||||||||||||
| ); | ||||||||||||||||||||
| if (lastError) { | ||||||||||||||||||||
| log.error( | ||||||||||||||||||||
|
|
||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new comment references removed behavior (
legacy config.calls.model) and PR history, which violates the documented comment standard inassistant/AGENTS.md(“comments should describe the current state of the codebase, not narrate its history”). Keeping history in inline comments tends to become stale and misleads future readers, so this should be rewritten to describe only the presentcallSitebehavior.Useful? React with 👍 / 👎.